Fix Taxi-v3 deprecation in tests (gymnasium 1.3.0 compatibility)#2247
Merged
Conversation
Contributor
Author
|
Also just so you are aware when using unrelated to my pull request. |
Removed it from deprecations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created function
_make_env_safe(env_id, **kwargs)to check if there exists agym.error.DeprecatedEnv. If said exception exists it checks the fallback hash map and if the env_id exists in the hash map then it uses that version else it raises an exception.Motivation and Context
It fixes the error
gymnasium.error.DeprecatedEnv: Environment version v3 for 'Taxi' is deprecated. Please use 'Taxi-v4' instead.In the test file
test_spaces.py:Specifically
tests/test_spaces.py::test_discrete_obs_spacecloses #2246
Types of changes
Checklist
docs/misc/changelog.md) (required).make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)make doc(required)